From 81986d24d5d8535303b7d4b96857c8d18d1e999e Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 13:51:31 -0700 Subject: [PATCH 01/12] Test alternative setup action --- action.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index 5d69c007f..08bb1cdac 100644 --- a/action.yml +++ b/action.yml @@ -79,10 +79,11 @@ runs: fi - name: Setup tfcmt - uses: shmokmt/actions-setup-tfcmt@v2 if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} - with: - version: v4.4.1 + uses: shirakiya/setup-tfcmt@v1.1.0 + # uses: shmokmt/actions-setup-tfcmt@v2 + # with: + # version: v4.4.1 - name: Configure Plan AWS Credentials if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} From 4c4e727d41ece19d3192ed9adc6a9ecc107f5cac Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 13:55:23 -0700 Subject: [PATCH 02/12] install node --- action.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/action.yml b/action.yml index 08bb1cdac..962037356 100644 --- a/action.yml +++ b/action.yml @@ -84,6 +84,9 @@ runs: # uses: shmokmt/actions-setup-tfcmt@v2 # with: # version: v4.4.1 + + - uses: actions/setup-node@v3 + if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} - name: Configure Plan AWS Credentials if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} From edf4a3072d88d7927a88adab78c9873e21d9c7a4 Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 13:57:26 -0700 Subject: [PATCH 03/12] install node --- action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index 962037356..ab20f5f56 100644 --- a/action.yml +++ b/action.yml @@ -78,6 +78,9 @@ runs: echo "actions_enabled=false" >> $GITHUB_OUTPUT fi + - uses: actions/setup-node@v3 + if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} + - name: Setup tfcmt if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} uses: shirakiya/setup-tfcmt@v1.1.0 @@ -85,9 +88,6 @@ runs: # with: # version: v4.4.1 - - uses: actions/setup-node@v3 - if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} - - name: Configure Plan AWS Credentials if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} uses: aws-actions/configure-aws-credentials@v2.2.0 From e71f73b04c0992923db0f17b6d0675b65b61708d Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 13:59:56 -0700 Subject: [PATCH 04/12] install node earlier --- action.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index ab20f5f56..def57ae54 100644 --- a/action.yml +++ b/action.yml @@ -54,6 +54,8 @@ runs: with: terraform_version: ${{ inputs.terraform_version }} + - uses: actions/setup-node@v3 + - uses: cloudposse/github-action-setup-atmos@1.0.2 with: atmos-version: ${{ inputs.atmos-version }} @@ -78,9 +80,6 @@ runs: echo "actions_enabled=false" >> $GITHUB_OUTPUT fi - - uses: actions/setup-node@v3 - if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} - - name: Setup tfcmt if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} uses: shirakiya/setup-tfcmt@v1.1.0 From c40ecde06fba089af537cbbf0dea70f18325792b Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 14:40:51 -0700 Subject: [PATCH 05/12] try setting path --- action.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/action.yml b/action.yml index def57ae54..0dcc3428b 100644 --- a/action.yml +++ b/action.yml @@ -80,12 +80,16 @@ runs: echo "actions_enabled=false" >> $GITHUB_OUTPUT fi + - name: Update path + shell: bash + run: | + echo "/usr/local/bin" >> $GITHUB_PATH + - name: Setup tfcmt if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} - uses: shirakiya/setup-tfcmt@v1.1.0 - # uses: shmokmt/actions-setup-tfcmt@v2 - # with: - # version: v4.4.1 + uses: shmokmt/actions-setup-tfcmt@v2 + with: + version: v4.4.1 - name: Configure Plan AWS Credentials if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} From 91b3f260edabd39604570feca1c6da0bc15fa40d Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 14:48:57 -0700 Subject: [PATCH 06/12] testing branch --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 0dcc3428b..58aea56d9 100644 --- a/action.yml +++ b/action.yml @@ -54,7 +54,7 @@ runs: with: terraform_version: ${{ inputs.terraform_version }} - - uses: actions/setup-node@v3 + #- uses: actions/setup-node@v3 - uses: cloudposse/github-action-setup-atmos@1.0.2 with: From c93efb07e4ad912d2d5ea4bb3b9fa727572ffc05 Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 14:50:16 -0700 Subject: [PATCH 07/12] added node --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 58aea56d9..0dcc3428b 100644 --- a/action.yml +++ b/action.yml @@ -54,7 +54,7 @@ runs: with: terraform_version: ${{ inputs.terraform_version }} - #- uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 - uses: cloudposse/github-action-setup-atmos@1.0.2 with: From da18cb4aa17e12197a93e720596e68e66709079f Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 14:56:20 -0700 Subject: [PATCH 08/12] debug node --- action.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/action.yml b/action.yml index 0dcc3428b..939a91022 100644 --- a/action.yml +++ b/action.yml @@ -105,6 +105,10 @@ runs: id: atmos-plan shell: bash run: | + echo $PATH + node --version + which node + PLAN_FILE=$(echo "${{ inputs.stack }}-${{ inputs.component }}-${{github.sha}}.planfile" | sed 's#/#_#g') PLAN_FILE_PATH=$(pwd) ATMOS_BASE_PATH=$GITHUB_WORKSPACE atmos terraform plan ${{ inputs.component }} \ From 90ce30d3f8ef2acb26fb02ded266f530f5f8b0c3 Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 15:02:24 -0700 Subject: [PATCH 09/12] pin node version --- action.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/action.yml b/action.yml index 939a91022..4c1739061 100644 --- a/action.yml +++ b/action.yml @@ -55,6 +55,8 @@ runs: terraform_version: ${{ inputs.terraform_version }} - uses: actions/setup-node@v3 + with: + node-version: 16 - uses: cloudposse/github-action-setup-atmos@1.0.2 with: From b32e05880ea56c66b4e44face00a7f7167928e9e Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 15:03:53 -0700 Subject: [PATCH 10/12] Removed debugging steps --- action.yml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/action.yml b/action.yml index 4c1739061..e5625ea54 100644 --- a/action.yml +++ b/action.yml @@ -82,10 +82,10 @@ runs: echo "actions_enabled=false" >> $GITHUB_OUTPUT fi - - name: Update path - shell: bash - run: | - echo "/usr/local/bin" >> $GITHUB_PATH + #- name: Update path + # shell: bash + # run: | + # echo "/usr/local/bin" >> $GITHUB_PATH - name: Setup tfcmt if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} @@ -107,10 +107,6 @@ runs: id: atmos-plan shell: bash run: | - echo $PATH - node --version - which node - PLAN_FILE=$(echo "${{ inputs.stack }}-${{ inputs.component }}-${{github.sha}}.planfile" | sed 's#/#_#g') PLAN_FILE_PATH=$(pwd) ATMOS_BASE_PATH=$GITHUB_WORKSPACE atmos terraform plan ${{ inputs.component }} \ From 68dd88b842a9c8e38d2f25405fbcc86a4a20f6e3 Mon Sep 17 00:00:00 2001 From: milldr Date: Fri, 7 Jul 2023 15:06:43 -0700 Subject: [PATCH 11/12] clean up --- action.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/action.yml b/action.yml index e5625ea54..5c125c54b 100644 --- a/action.yml +++ b/action.yml @@ -82,10 +82,12 @@ runs: echo "actions_enabled=false" >> $GITHUB_OUTPUT fi - #- name: Update path - # shell: bash - # run: | - # echo "/usr/local/bin" >> $GITHUB_PATH + # setup-tfcmt requires this PATH update when running on self-hosted (amazon linux) + # https://github.com/shmokmt/actions-setup-tfcmt/blob/main/action.yml#L11C1-L12C1 + - name: Update path + shell: bash + run: | + echo "/usr/local/bin" >> $GITHUB_PATH - name: Setup tfcmt if: ${{ fromJSON(steps.settings.outputs.actions_enabled) }} From 1ec97a219276e6a685288972ac1475c73fb0ac96 Mon Sep 17 00:00:00 2001 From: Dan Miller Date: Fri, 7 Jul 2023 19:19:16 -0700 Subject: [PATCH 12/12] Update action.yml Co-authored-by: Erik Osterman (CEO @ Cloud Posse) --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 5c125c54b..09304ae52 100644 --- a/action.yml +++ b/action.yml @@ -58,7 +58,7 @@ runs: with: node-version: 16 - - uses: cloudposse/github-action-setup-atmos@1.0.2 + - uses: cloudposse/github-action-setup-atmos@v1 with: atmos-version: ${{ inputs.atmos-version }} token: ${{ inputs.token }}