Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TLS for gRPC / 在 gRPC 中支持 TLS #6

Closed
PureWhiteWu opened this issue Aug 10, 2022 · 6 comments
Closed

Support TLS for gRPC / 在 gRPC 中支持 TLS #6

PureWhiteWu opened this issue Aug 10, 2022 · 6 comments
Labels
A-volo-grpc This issue concerns the `volo-grpc` crate. C-feature-accepted This feature request is accepted. E-hard This is hard.

Comments

@PureWhiteWu
Copy link
Member

Feature Request

Crates

volo-grpc

Motivation

Currently we don't support TLS in gRPC, we need to support it.

目前 volo-grpc 不支持 TLS，我们应当支持一下。

Proposal

TBD
@PureWhiteWu PureWhiteWu added A-volo-grpc This issue concerns the `volo-grpc` crate. C-feature-accepted This feature request is accepted. E-hard This is hard. labels Aug 10, 2022
@carllhw
Copy link
Contributor

carllhw commented Apr 16, 2023

有啥进展吗

@PureWhiteWu
Copy link
Member Author

@carllhw 目前还没有，暂时没有收到相关的需求。

@carllhw
Copy link
Contributor

carllhw commented Apr 19, 2023

可以提个需求吗，现在因为tls而只能选择tonic了，涉及到公网的grpc stream交互

@minghuaw minghuaw mentioned this issue Oct 25, 2023
Merged
@PureWhiteWu
Copy link
Member Author

@minghuaw 在 #247 中支持了 TLS， @carllhw 有需求的话可以试一下？

@minghuaw
Copy link
Contributor

minghuaw commented Oct 27, 2023 •
edited
Loading

@PureWhiteWu @carllhw I just realized that there was a problem in the initial implementation. The server would return an error should an incoming TLS handshake fail. I will make another PR to fix this.

Edit: a new PR has been submitted (#250)

@GuangmingLuo
Copy link
Member

@minghuaw hi, Thanks for your contribution. I have sent an email to you. Please take a look and reach out to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-volo-grpc This issue concerns the `volo-grpc` crate. C-feature-accepted This feature request is accepted. E-hard This is hard.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PureWhiteWu @carllhw @GuangmingLuo @minghuaw