Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code duplication found #884

Open
adavidzh opened this issue Dec 16, 2023 · 0 comments · May be fixed by #989
Open

Code duplication found #884

adavidzh opened this issue Dec 16, 2023 · 0 comments · May be fixed by #989
Labels
enhancement needs work

Comments

@adavidzh
Copy link
Member

I just noticed this code duplication in case some refactoring effort surfaces: https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/man/src/ProcessNormalization.cc#L112-L129 and https://github.com/cms-analysis/HiggsAnalysis-CombinedLimit/blob/main/src/AsymPow.cc#L33-L56
pitkajuh added a commit to pitkajuh/HiggsAnalysis-CombinedLimit that referenced this issue Jul 6, 2024
@pitkajuh
Fix cms-analysis#884, remove code repetition in ProcessNormalization …
14e8707 
…and AsymPow regarding logKappaForX
@pitkajuh pitkajuh linked a pull request Jul 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs work
Projects
None yet
Milestone
No milestone
1 participant
@adavidzh