-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vamos - interactive programs don't register keypresses #216
Comments
The whole console handling especially in raw mode is very incomplete in vamos. I have better console support planned and its one of my next tasks... That said, I will have a look on your failing game if you could give me some details. You could also investigate by enabling more debug output: e.g. |
Thanks! Here's a simple one (there are a ton of STDIO games and none of them seem to work fully). This one seems to launch fine but won't recognize any keypresses or inputs from the client. https://aminet.net/package/comm/bbs/Achess13 Pasted the log below based on the instructions you gave, please note I had to ctrl-c to quit so that might be some of the error messages here (unclear to me though).
|
Thanks for the binary. I could reproduce the issue. vamos did not stop the read on a line ending in the console... that caused the block. I have pushed a fix in 3bc6aee. This is on my Please retest and report the next fail :) |
Thanks! Cursory test and things are working here. I should mention I did not follow your instructions as it pertains to Just as an FYI, my use case is to serve Amiga BBS door games written to output in STDIO from my linux BBS. In essence to revive some of the old and cool games. Thanks again for the help! I'll follow up soon with more findings (if any). |
Ok - second game having issues. This one is called "Deep Space Empire" - download link on aminet is here. There are two issues with this game so far that I can notice. The first of which is that when I launch Launching works, I can select the options at the intro menu. However if I choose option 1 and try to answer the prompt with my username, it just spits out what I entered but fails to move past this screen.
|
If a program needs options with dashes then you need to terminate the option parsing of vamos itself with a double dash:
This is required by the option parser and can't be "fixed"... Regarding the runtime problem I have no clue yet what goes wrong :( If I compare the behaviour on OS 3.2 with vamos I already see that the first interaction ("do you have an ANSI terminal?") already breaks... On Amiga you enter a single char but on vamos you have to add a return.... This unfortunately skips the next question ("IBM charset?") completely.... I suspected its related to Raw/Cooked mode of the terminal, but I don't see the associated calls.... |
Got it. Ok. Is there anything else I can provide with this binary to see if we can further diagnose? I really appreciate your help :) Alternatively if you think this one may not go anywhere, I can easily switch to another binary. Please let me know what makes sense. Honestly there aren't a ton of these old STDIO games so hopefully making one or two of them work completely will suffice for the other games as well. |
Dreamsweeper's a game I can't get to launch using vamos. It doesn't output anything when running vamos, nor does increased logging do much. Perhaps this one is simpler to troubleshoot :) https://aminet.net/comm/bbs/dRMSWR11.lha Grotte is another one that doesn't launch at all and there is nothing in logs. https://aminet.net/comm/bbs/GrotteDemo.lha - does launching a binary in vamos take the tooltype of the binary into account? This game needs some tooltypes set. Global war is one that needs to be in DOORS:globalwar - the archive is here - https://aminet.net/comm/bbs/GW221e.lha - this one has the same issue of failing when I have to enter my username. Perhaps there is better info in the log?
|
Thanks for all the samples :) I need to have a look at them later... I found the fix for Deep Space Empire... now RAW mode works :) Please use latest dev on both amitools and machine68k to test... |
Awesome! I'm happy to report GlobalWar now deals with hotkeys correctly as well as full text input. Score! I have no idea how to play this game to actually test it though lol. But this is great :) DSE appears to work as well! Guess I need to figure out how to play that one so I can test it. DreamSweeper and Grotte still do not work (mentioned those in my last comment). I have a whole list of 16 STDIO games that I'm testing and ideally hoping to run. Let me know if this type of iterative process that we're doing now works for you or if you'd like me to do something different in how I'm testing and reporting things to you. Thanks again, this is really awesome from where I sit and I can't wait to host these games on my linux bbs :) |
I'd suggest that you create a table here in the comments listing all the games, their source link, and their current status (works/does not work). For the non-working games a description column may be helpful that describes the failure. On top you could even add a file link with a debug log of the failed run attached... Then I could go through the list and annotate (in an own column) what needs to be done on vamos side or what's missing... |
There are probably other STDIO games I'll find along the way (roguelikes?) which I can add here as well but I'll leave the list as is for the time being. For completeness, this is my
Thanks! |
Some notes on the games:
|
I've been trying to run a number of stdio text games and they start up just fine but when I'm prompted to input text, the programs don't respond. It's like they hang on waiting for character entry.
I'm using latest from tip of master today (1/15/2025). Please let me know how I can help troubleshoot, thanks!
The text was updated successfully, but these errors were encountered: