splinter 0.7.7 breaks 0.7.5 functionality

[sureshvv]

It seems buttons HAVE to be inside forms in 0.7.7.

Otherwise I get:

Traceback (most recent call last):
   File "/home/suresh/appt/myproject/appt/tests/test_blackout2.py", line 96, in test_delete
    browser.find_by_name('login').click()
  File "/home/suresh/appt/local/lib/python3.5/site-packages/splinter/driver/lxmldriver.py", line 397, in click
    return self.parent.submit_data(parent_form)
  File "/home/suresh/appt/local/lib/python3.5/site-packages/splinter/driver/djangoclient.py", line 121, in submit_data
    return super(DjangoClient, self).submit(form).content
  File "/home/suresh/appt/local/lib/python3.5/site-packages/splinter/driver/lxmldriver.py", line 74, in submit
    data = self.serialize(form)
  File "/home/suresh/appt/local/lib/python3.5/site-packages/splinter/driver/lxmldriver.py", line 48, in serialize
    form.remove(input)
  File "src/lxml/lxml.etree.pyx", line 950, in lxml.etree._Element.remove (src/lxml/lxml.etree.c:50799)
ValueError: Element is not a child of this node.

[andrewsmedina]

it looks like a bug. I will try to reproduce it

[andrewsmedina]

@sureshvv can you add your html and the code that uses splinter to make possible to me reproduce this bug?

[sureshvv]

The html:

bug.zip

The code:

      from splinter import Browser
      browser = Browser('django')
      browser.visit('/login')
      browser.find_by_id('user-email').fill('jacob')
      browser.fill('password', 'top_secret')
      browser.find_by_name('login').click()

[blueyed]

The problem here is basically that the element is not a direct child of the form.
But also note that the form should not get modified really, and there might be better methods. See #1059.