Refactor 2d assembler #17659
Merged
Refactor 2d assembler #17659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -3520,9 +3520,16 @@
/**
* @internal
*/
export interface IAssembler {
- [key: string]: any;
+ createData?(comp: UIRenderer): BaseRenderData;
+ fillBuffers?(comp: UIRenderer, renderer: __private._cocos_2d_renderer_i_batcher__IBatcher): void;
+ updateUVs?(comp: UIRenderer, ...args: any[]): void;
+ updateColor?(comp: UIRenderer): void;
+ updateRenderData?(comp: UIRenderer): void;
+ update?(comp: UIRenderer, dt: number): void;
+ resetAssemblerData?(data: any): void;
+ removeData?(data: BaseRenderData): void;
}
/**
* @internal
*/
@@ -46349,9 +46356,9 @@
* // Remove all living segments of the ribbon.
* myMotionStreak.reset();
*/
reset(): void;
- lateUpdate(dt: any): void;
+ lateUpdate(dt: number): void;
/**
* @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
*/
_render(render: __private._cocos_2d_renderer_i_batcher__IBatcher): void;
@@ -68260,10 +68267,10 @@
dir: math.Vec2;
distance: number;
time: number;
constructor(point?: math.Vec2, dir?: math.Vec2);
- setPoint(x: any, y: any): void;
- setDir(x: any, y: any): void;
+ setPoint(x: number, y: number): void;
+ setDir(x: number, y: number): void;
}
export enum _cocos_particle_enum__ParticleSpace {
World = 0,
Local = 1,
|
…efactor-2d-assembler # Conflicts: # cocos/2d/assembler/label/index.ts
|
@cocos-robot run test cases |
This reverts commit ee77f23.
|
@cocos-robot run test cases |
…efactor-2d-assembler # Conflicts: # cocos/2d/assembler/label/bmfontUtils.ts # cocos/2d/assembler/label/letter-font.ts # cocos/2d/assembler/label/ttf.ts # cocos/2d/assembler/sprite/bar-filled.ts # cocos/2d/assembler/sprite/simple.ts # cocos/2d/assembler/sprite/sliced.ts # cocos/2d/assembler/sprite/tiled.ts # cocos/2d/components/label.ts # cocos/2d/components/sprite.ts # cocos/particle-2d/particle-system-2d.ts
…efactor-2d-assembler
|
@cocos-robot run test cases |
minggo
approved these changes
Feb 5, 2025
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details
|
# Conflicts: # cocos/2d/assembler/graphics/webgl/graphics-assembler.ts # cocos/2d/assembler/graphics/webgl/index.ts # cocos/particle-2d/particle-system-2d.ts # cocos/spine/skeleton.ts
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
|
@cocos-robot run test cases |
|
@dumganhar, Please check the result of
Task Details
|
|
@dumganhar, Please check the result of
Task Details |
|
@minggo, this PR is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: