why is the logging level set to info for root logger?

[modernNeo]

I am wondering why, in the getmail command, you have set the root logger's config level to INFO instead of setting the config level for getmail to INFO like this logger.setLevel(level=logging.INFO)

django-mailbox/django_mailbox/management/commands/getmail.py

Lines 7 to 10 in 40263b6

	logger = logging.getLogger(__name__)
	logging.basicConfig(level=logging.INFO)

[coddingtonbear]

That's done so logging messages will be emitted to the console; since that's a command-line entrypoint, some amount of user feedback is desirable. The call tobasicConfig is doing more than just setting the logging level for the root logger -- it's also wiring things up so they'll be printed to the console. Using logging.info here will allow all INFO-level and higher logging messages to make it to the console, regardless of what module they're emitted from.

[coddingtonbear]

It's probably not a great idea to call command-line entrypoints directly from your own logic, but I have to say that just now having glanced at that module, I'm a little surprised about the particular approach I took for setting up the logger.

What's probably the right choice is moving the logic called in the handler method into its own function somewhere. That way, both the command-line entrypoint and user logic (yours) can invoke that logic without you needing to import the command-line class directly.

[modernNeo]

What's probably the right choice is moving the logic called in the handler method into its own function somewhere. That way, both the command-line entrypoint and user logic (yours) can invoke that logic without you needing to import the command-line class directly.

That I agree with. When do you think you can get to that?

[coddingtonbear]

Oh, "never" is unfortunately the answer to that question. If you were to post a PR doing that, though, you'd be one step closer to getting changes like that made.

[modernNeo]

Sure, I got no problems making the PR myself. just have to ask you where you would like me to place that bit of logic? a new file or an existing python file in your module?

[modernNeo]

@coddingtonbear PR opened: #264

[pfouque]

Looks solved

[modernNeo]

github discussions have to be marked as solved and closed?