Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #120

Open
code423n4 opened this issue Apr 7, 2022 · 0 comments · Fixed by with-backed/backed-protocol#71
Open

QA Report #120

code423n4 opened this issue Apr 7, 2022 · 0 comments · Fixed by with-backed/backed-protocol#71
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Thanks for a very well documented and tested codebase.

Just one note to pass on here: there's a typo in the terms maxPerAnumInterest and perAnumInterestRate, which are used in a few places in the codebase. This should be "per annum" to mean "per year." (Or just consider "per year" or "annual" in English instead). The phrase "per anum" is a medical term that means something entirely different :)
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 7, 2022
code423n4 added a commit that referenced this issue Apr 7, 2022
@code423n4
horsefacts issue #120
9248d05
@wilsoncusack wilsoncusack added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Apr 8, 2022
@wilsoncusack wilsoncusack mentioned this issue Apr 15, 2022
Merged
@wilsoncusack wilsoncusack added the resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) label Apr 15, 2022
@JeeberC4 JeeberC4 reopened this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax resolved Finding has been patched by sponsor (sponsor pls link to PR containing fix) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addressing various gas and QA nits with-backed/backed-protocol
3 participants
@wilsoncusack @code423n4 @JeeberC4