Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #128

Open
code423n4 opened this issue Apr 7, 2022 · 0 comments
Open

Gas Optimizations #128

code423n4 opened this issue Apr 7, 2022 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

  1. Using < is cheaper than <=

Proof of Concept:
https://github.com/code-423n4/2022-04-backed/blob/main/contracts/NFTLoanFacilitator.sol#L146-L148
https://github.com/code-423n4/2022-04-backed/blob/main/contracts/NFTLoanFacilitator.sol#L171-L172

Recommended Mitigation Steps:
Change from <= to <

require(interestRate < loan.perAnumInterestRate, 'NFTLoanFacilitator: rate too high');

========================================================================

  1. !=0 is more gas efficient than < 0

Proof of Concept:
https://github.com/code-423n4/2022-04-backed/blob/main/contracts/NFTLoanFacilitator.sol#L198
https://github.com/code-423n4/2022-04-backed/blob/main/contracts/NFTLoanFacilitator.sol#L321

Recommended Mitigation Steps:
Change > 0 or < 0 to != 0

========================================================================

  1. Using calldata to store struct data type can save gas

Proof of Concept:
https://github.com/code-423n4/2022-04-backed/blob/main/contracts/NFTLoanFacilitator.sol#L332

Recommended Mitigation Steps:
Change to:

function loanInfoStruct(uint256 loanId) external view override returns (Loan calldata) {

========================================================================
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Apr 7, 2022
code423n4 added a commit that referenced this issue Apr 7, 2022
@code423n4
Tomio issue #128
0796b94
@wilsoncusack wilsoncusack added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilsoncusack @code423n4