Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #93

Open
code423n4 opened this issue Apr 7, 2022 · 1 comment
Open

QA Report #93

code423n4 opened this issue Apr 7, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Non Critical

Use memory instead of storage, when you just read state vars:

It's more readable to use memory keyword, when we don't want to write changes or just read the state vars.

It's also more gas efficient but these are external view functions so gas doesn't matter here.

@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Apr 7, 2022
code423n4 added a commit that referenced this issue Apr 7, 2022
@adamgobes adamgobes added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Apr 8, 2022
@wilsoncusack
Copy link
Collaborator

using memory unnecessary copies the whole struct into memory which is not needed. This is more gas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

3 participants