QA Report #93
Labels
bug
Something isn't working
QA (Quality Assurance)
Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
sponsor acknowledged
Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Non Critical
Use
memory
instead ofstorage
, when you just read state vars:It's more readable to use
memory
keyword, when we don't want to write changes or just read the state vars.It's also more gas efficient but these are external view functions so gas doesn't matter here.
The text was updated successfully, but these errors were encountered: