Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Optimizations #449

Open
code423n4 opened this issue Jul 14, 2023 · 3 comments
Open

Gas Optimizations #449

code423n4 opened this issue Jul 14, 2023 · 3 comments
Labels
bug Something isn't working G (Gas Optimization) G-03 grade-a sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

See the markdown file with the details of this report here.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jul 14, 2023
code423n4 added a commit that referenced this issue Jul 14, 2023
@code423n4
SAQ issue #449
c395ae7
code423n4 added a commit that referenced this issue Jul 14, 2023
@code423n4
SAQ data for issue #449
9d608cf
@c4-judge
Copy link
Contributor

Picodes marked the issue as grade-a

@c4-sponsor
Copy link

asselstine marked the issue as sponsor confirmed

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jul 20, 2023
@C4-Staff C4-Staff added the G-03 label Aug 15, 2023
@PierrickGT
Copy link
Member

G-1, 6, 12: has been fixed
G-2: constants can't be private
G-3, 4: does not save any gas
G-5, 7, 11, 13, 14: we would lose in code legibility
G-8: is handled by safeTransfer
G-9: values are assigned, not accessed
G-10: we won't implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) G-03 grade-a sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@PierrickGT @code423n4 @c4-judge @c4-sponsor @C4-Staff