Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inappropriate calculation of totalAmountOwed #5

Open
bejayjoshua opened this issue Jan 3, 2025 · 0 comments
Open

Inappropriate calculation of totalAmountOwed #5

bejayjoshua opened this issue Jan 3, 2025 · 0 comments

Comments

@bejayjoshua
Copy link

"int96 newBalance = currentBalance + amountLinkOwed;"

" if (currentBalance > 0) {
totalAmountOwed -= uint256(int256(currentBalance));"
if (newBalance > 0) {

    totalAmountOwed += uint256(int256(newBalance));
  
 From the above code, it could be seen that after subtracting the currentBalance from the totalAmountOwed, the currentBalance was later added to the totalAmountOwed by adding newBalance to it.  Hence newBalance = currenttBalance + amountLinkOwed.  
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant