Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit to window doesn't turn off correctly #1828

Closed
Korygauger opened this issue Nov 13, 2023 · 8 comments · Fixed by #1835
Closed

Fit to window doesn't turn off correctly #1828

Korygauger opened this issue Nov 13, 2023 · 8 comments · Fixed by #1835
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@Korygauger
Copy link

Bug Report:

BUG: fit to window doesn't turn off without tab refresh
HOW: open a video turn on fit to window and then turn it off.
you will find that when you turn it off theater mode is cropped essentially cutting off the borders of the video and normal mode becomes weirdly vertical. the fit to window view looks fine though.

Screenshots:
defaultView
fit to window
theatermode

/ ⚬ Context:
I think it just isn't updating the new size to the player and is instead putting the fit to window size video in the now smaller video box but that is just speculation on my part.
A quick fix to this would be to make fit to window become the default viewing mode cause it works normally otherwise. It does stay on though when I click a video in the recommended videos under the current video, but if I go back to my home page and select a new video from there it isn't on and becomes broken.

this is the first version of your extension I have used from you guys so I wouldn't know what update caused this.

sorry if this was already reported. I did look but I my skills may be lacking in that regard so I could have missed it.

/ ⚬ Expected /preferred behavior:
⚬ Browser: Mercury, repeatable on firefox and vivaldi
⚬ Settings: repeatable on default settings with just fit to window enabled
⚬ OS: linux mint

sorry if this wasn't very helpful this is my first bug report.

@Korygauger Korygauger added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Nov 13, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 14, 2023

hi! @Korygauger, thanks! couldn't reproduce it yet

this player button is new #1798 by @D-Rekk

firefox addon store allows to test an old version of our extension with a click.

you can also try to log out, since YouTube changed a lot these days. And might give you different versions.

@D-Rekk
Copy link
Contributor

D-Rekk commented Nov 14, 2023

I don't understand completely how that occurs. @Korygauger can you post a video replicating the issue without any other extension? Currently in Chromium this works well (at least the version I'm using 👀) by toggling both FTW and theater on and off.

@Korygauger
Copy link
Author

Hey @D-Rekk and @ImprovedTube so I checked what you guys said other than the older version so I still have to test that but here is a video link to how recreate the bug. https://youtu.be/d-D-pNDtwtc .

@D-Rekk
Copy link
Contributor

D-Rekk commented Nov 15, 2023

Thank you @Korygauger 🙏. Since you haven't changed any other settings, this has to be related to issue #1685, which also affects this feature. I just pushed a fix in my fork, may you verify if this problem occurs with this branch too?

@Korygauger
Copy link
Author

@D-Rekk I tried to install your fork but I am not sure how I can. I tried downloading the .zip renaming to .xpi and installing from file but it says it is corrupted. Can you tell me how I can install it?

@D-Rekk
Copy link
Contributor

D-Rekk commented Nov 15, 2023

@Korygauger you have to download the zip and open/extract it. That folder will appear with lots of files, just as the repository itself. Then you go into your browser settings, in Extensions Settings you import an unpacked extension (the folder just extracted).

@Korygauger
Copy link
Author

@D-Rekk worked like a charm. whatever you did. can you let me know when your push request goes through?

@ImprovedTube
Copy link
Member

thanks guys!!

  • Added a new label "bounty" to BrainStorming: 1. 'normal' vs null ?? & 2. Active Features GUI  #1685 etc. (Wish the development can be as efficient as possible, while the project grows).
  • Reports just increased noticeably (& nicely) through mentioning github issues on the uninstall page (several reports by people who just signed up on github, yet knowledgable)
    • We should get donations / funding, so that pure service (or "sisyphos-tasks" after YouTube Updates) won't depend only on great volunteers, like @D-Rekk (, which can be tough, so sometimes it feels funny, that we (the many users) are collectively begging the few contributors (developers, reporters /testers, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants