Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CodeCorps.Emails.Transmissions.Receipt #1337

Open
begedin opened this issue Dec 22, 2017 · 0 comments
Open

Clean up CodeCorps.Emails.Transmissions.Receipt #1337

begedin opened this issue Dec 22, 2017 · 0 comments

Comments

@begedin
Copy link
Contributor

begedin commented Dec 22, 2017

Problem

In #1332, and even before that, CodeCorps.Emails.Transmissions.Receipt.build is wrapped into a with statement with multiple points of failure.

The event handler code which sends this email also wrapps that call into multiple points of failure.

The border between these seems arbitrary and, more importantly, The behavior of the Receipt itself is inconsistent with all other emails.

We should move these points of failure into the event handler and keep the Receipt itself infallible.

Then, we should decide if the points of failure actually make sense or if it's too defensive. This is old code, so it's quite possible we made some mistakes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant