From 48325ed5d51710fc0cfb9474f9f826f900bb439e Mon Sep 17 00:00:00 2001 From: Josh Smith Date: Wed, 27 Dec 2017 13:48:41 -0800 Subject: [PATCH] chore(package): update ember-cli-password-strength to version 2.0.0 (#1490) * chore(package): update ember-cli-password-strength to version 2.0.0 Closes #1458 * Migrate app to new version of ember-cli-password-strength --- app/components/signup-password-input.js | 8 ++++---- ember-cli-build.js | 3 +++ package.json | 2 +- yarn.lock | 8 ++++---- 4 files changed, 12 insertions(+), 9 deletions(-) diff --git a/app/components/signup-password-input.js b/app/components/signup-password-input.js index e9374ae41..27b6ce77d 100644 --- a/app/components/signup-password-input.js +++ b/app/components/signup-password-input.js @@ -1,13 +1,13 @@ import Component from '@ember/component'; -import { computed } from '@ember/object'; +import { computed, get } from '@ember/object'; import { not, lt, gte, alias } from '@ember/object/computed'; import { inject as service } from '@ember/service'; -import strength from 'password-strength'; export default Component.extend({ classNames: ['input-group'], ajax: service(), + passwordStrength: service(), canShowValidations: alias('isNotEmpty'), isEmpty: lt('passwordLength', 1), @@ -23,8 +23,8 @@ export default Component.extend({ }), strength: computed('password', function() { - let password = this.get('password') || ''; - return strength(password); + let passwordStrength = get(this, 'passwordStrength'); + return passwordStrength.strengthSync(get(this, 'password')); }), strengthPercentage: computed('isValid', 'passwordLength', 'strength', function() { diff --git a/ember-cli-build.js b/ember-cli-build.js index 409739c33..b509cb527 100644 --- a/ember-cli-build.js +++ b/ember-cli-build.js @@ -29,6 +29,9 @@ module.exports = function(defaults) { // async, await, etc. includePolyfill: true }, + 'ember-cli-password-strength': { + bundleZxcvbn: true + }, fingerprint: fingerprintOptions, emberCLIDeploy: { // runOnPostBuild: (env === 'development') ? 'development-postbuild' : false, diff --git a/package.json b/package.json index 14174967e..cd7bb4e74 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,7 @@ "ember-cli-moment-shim": "^3.4.0", "ember-cli-neat": "^0.0.6", "ember-cli-page-object": "1.12.1", - "ember-cli-password-strength": "1.0.3", + "ember-cli-password-strength": "^2.0.0", "ember-cli-qunit": "^4.1.1", "ember-cli-release": "^0.2.9", "ember-cli-sass": "^7.0.0", diff --git a/yarn.lock b/yarn.lock index 89eea8b51..2cb48d6c2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3008,13 +3008,13 @@ ember-cli-page-object@1.12.1: ember-test-helpers "^0.6.3" rsvp "^3.2.1" -ember-cli-password-strength@1.0.3: - version "1.0.3" - resolved "https://registry.yarnpkg.com/ember-cli-password-strength/-/ember-cli-password-strength-1.0.3.tgz#690a7771bbb6e9c4994a73259df4df785a2287df" +ember-cli-password-strength@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/ember-cli-password-strength/-/ember-cli-password-strength-2.0.0.tgz#f6f16d5c42ac16a4605305244f15f092f15224b3" dependencies: broccoli-funnel "^1.1.0" broccoli-merge-trees "^2.0.0" - ember-cli-babel "^6.0.0" + ember-cli-babel "^6.8.0" zxcvbn "^4.3.0" ember-cli-path-utils@^1.0.0: