Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code paths for sharing #515

Open
Erin007 opened this issue Nov 28, 2018 · 0 comments
Open

Duplicated code paths for sharing #515

Erin007 opened this issue Nov 28, 2018 · 0 comments
Labels
external Fix in the main code-dot-org codebase p1
Milestone
Post HOC

Comments

@Erin007
Copy link
Contributor

Erin007 commented Nov 28, 2018

Sharing from the Finish Dialog and the Share Dialog takes 2 separate code paths via 2 separate sets of very similar buttons 😞. These buttons should be Reactified and the paths consolidated.

More details: code-dot-org/code-dot-org#26244 (comment)
@Erin007 Erin007 added the external Fix in the main code-dot-org codebase label Nov 28, 2018
@ryansloan ryansloan added this to the Post HOC milestone Nov 28, 2018
@simplycloud simplycloud added the p1 label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Fix in the main code-dot-org codebase p1
Projects
None yet
Milestone
Post HOC
Development

No branches or pull requests
3 participants
@ryansloan @simplycloud @Erin007