From 61af9e1a53359837f5dbec9c4485cdc25b9453e8 Mon Sep 17 00:00:00 2001
From: hanna-skryl <hanna.skryl@gmail.com>
Date: Thu, 24 Oct 2024 13:34:06 -0400
Subject: [PATCH] test: remove portal-client

---
 .../tests/executor-cli.e2e.test.ts            | 29 +------------------
 1 file changed, 1 insertion(+), 28 deletions(-)

diff --git a/e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts b/e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
index 2b76eadc2..c7f12d34e 100644
--- a/e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
+++ b/e2e/nx-plugin-e2e/tests/executor-cli.e2e.test.ts
@@ -1,14 +1,6 @@
-import {
-  type Tree,
-  addDependenciesToPackageJson,
-  readJsonFile as readPackageJsonFile,
-  removeDependenciesFromPackageJson,
-  updateProjectConfiguration,
-} from '@nx/devkit';
+import { type Tree, updateProjectConfiguration } from '@nx/devkit';
 import { join, relative } from 'node:path';
-import { fileURLToPath } from 'node:url';
 import { readProjectConfiguration } from 'nx/src/generators/utils/project-configuration';
-import type { PackageJson } from 'nx/src/utils/package-json';
 import { afterEach, expect } from 'vitest';
 import { generateCodePushupConfig } from '@code-pushup/nx-plugin';
 import {
@@ -65,36 +57,17 @@ async function addTargetToWorkspace(
   await materializeTree(tree, cwd);
 }
 
-const getPortalClientVersion = (): string => {
-  const projectRoot = join(fileURLToPath(import.meta.url), '../../../../');
-  const packageJsonPath = join(projectRoot, 'package.json');
-  return (
-    readPackageJsonFile<PackageJson>(packageJsonPath).dependencies?.[
-      '@code-pushup/portal-client'
-    ] || '^0.9.0'
-  );
-};
-
 describe('executor command', () => {
   let tree: Tree;
   const project = 'my-lib';
   const baseDir = 'tmp/e2e/nx-plugin-e2e/__test__/executor/cli';
-  const portalClientVersion = getPortalClientVersion();
 
   beforeEach(async () => {
     tree = await generateWorkspaceAndProject(project);
-
-    // @code-pushup/portal-client is required by the executor to handle the upload in tests
-    addDependenciesToPackageJson(
-      tree,
-      { '@code-pushup/portal-client': portalClientVersion },
-      {},
-    );
   });
 
   afterEach(async () => {
     await teardownTestFolder(baseDir);
-    removeDependenciesFromPackageJson(tree, ['@code-pushup/portal-client'], []);
   });
 
   it('should execute no specific command by default', async () => {