Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the option onlyPlugins need rethinking #298

Closed
BioPhoton opened this issue Nov 21, 2023 · 2 comments
Closed

the option onlyPlugins need rethinking #298

BioPhoton opened this issue Nov 21, 2023 · 2 comments
Labels
🐛 bug something isn't working 🧩 cli
Milestone

Comments

@BioPhoton
Copy link
Collaborator

BioPhoton commented Nov 21, 2023

The option onlyPlugins remove a whole category if 1 audit is included. This is no good DX as when debugging I want to see the category scores too. A potential solution could be just remove refs from a category, not the category it self.

blocked by #515 as it includes a helper function to filter refs in a category

@BioPhoton BioPhoton added the 🐛 bug something isn't working label Nov 21, 2023
@BioPhoton BioPhoton added this to the 2. Integration milestone Nov 21, 2023
@vmasek vmasek modified the milestones: 2. Integration, 4. Public Mar 7, 2024
@vmasek
Copy link
Collaborator

vmasek commented Jul 18, 2024

@BioPhoton please check if the category audits are still replaced or if they get merged. If the case is replacement, please update the issue

@hanna-skryl
Copy link
Collaborator

Since the issue was created, the filtering logic has been updated and centralized within a single filtering middleware function: #822 and #831.

The current behavior already matches what was requested: categories are kept, and only specific references within them are filtered out based on the onlyPlugins and skipPlugins options. The middleware uses the filterItemRefsBy helper function (introduced in #515) to filter references within a category, ensuring that categories remain intact while filtering only the relevant plugin references, providing the expected developer experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 cli
Projects
None yet
Development

No branches or pull requests

3 participants