New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of points I noticed. #6

Open

elextr opened this issue Oct 16, 2012 · 1 comment

elextr commented Oct 16, 2012

Couple of points I noticed, wasn't by any means a real review.

some of the keybindings clash with standard ones, ++e and t at least, didn't check all the rest.
in zen_controller_init_python() the variable resident_pylib is static so its only ever initialised to NULL once, not sure if thats part of your commented intermittent crash on subsequent calls
even if the python lib isn't found you fall through to try to initialise anyway, that would probably be a crash.

Owner

codebrainz commented Oct 16, 2012

That's all you found? :)

I haven't even really touched this since last year, so not too bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment