Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected issues - update prettier #480

Open
efueger opened this issue Mar 9, 2020 · 1 comment
Open

unexpected issues - update prettier #480

efueger opened this issue Mar 9, 2020 · 1 comment
Assignees

Comments

@efueger
Copy link
Member

efueger commented Mar 9, 2020

A customer wrote in reporting they're encountering a large number of codeclimate errors indicating there's a discrepancy somewhere and it's not linting to the same set of rules.

I think the source might be the the prettier dependency version used by the plugin.


Customer's using eslint-5,

(I tried Contributing instructions, but ran into other dependencies that will need to be upgraded. I prefer a second set of eyes/hands to help with this.)

@efueger efueger self-assigned this Mar 9, 2020
@sinani
Copy link

sinani commented Jun 21, 2021

latest prettier version is v6.10.0

Latest prettier version is 2.3.1. You're linking to eslint-config-prettier project.

You need to install an exact Prettier version.
https://prettier.io/docs/en/install.html

Install an exact version of Prettier locally in your project. This makes sure that everyone in the project gets the exact same version of Prettier. Even a patch release of Prettier can result in slightly different formatting, so you wouldn’t want different team members using different versions and formatting each other’s changes back and forth.

And I suspect further complications related to eslint-plugin-prettier and/or eslint-config-prettier as well, but that's something I'm trying to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants