Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get comments from GLIDE list #189

Open
stevieflow opened this issue Jul 5, 2021 · 5 comments
Open

Get comments from GLIDE list #189

stevieflow opened this issue Jul 5, 2021 · 5 comments

Comments

@stevieflow
Copy link

Re: https://github.com/codeforIATI/humanitarian-emergency-codelists

Coudl the comment field also be imported? This gives a useful description across the emergencies. For example 32 comments reference "ebola", whereas the titles do not

@andylolz
Copy link
Member

andylolz commented Jul 5, 2021

The comments are useful, but I have a feeling @markbrough said it’s a bit trickier to scrape.

@markbrough
Copy link
Member

I didn't really look into it but I assume it should be fairly straightforward - I think it was just that it would significantly increase the size of the files. But maybe that is fine?

@stevieflow
Copy link
Author

It will add to the file size, I agree - but will significantly improve the search function

(note - the searching of this codelist seems a liitle shaky atm, maybe because of it's size...)

@markbrough
Copy link
Member

Yup I agree with both of these points! Searching is very slow at the moment on large lists, and will likely be substantially slower if we add in the comments field. Perhaps there are improvements to the search function that we could make -- there is already a ticket for this: codeforIATI/codelists#72

@andylolz
Copy link
Member

andylolz commented Jul 16, 2021

I just realised the comments already get scraped – I guess @markbrough already did that work!
https://codeforiati.org/humanitarian-emergency-codelists/glide-emergencies.csv

So yeah, the file size is the only issue here (and therefore the search).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants