ESLint関連パッケージを更新 #476
Merged
ESLint関連パッケージを更新 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munierujp
commented
Jan 10, 2024
| @@ -9,6 +9,7 @@ try { | |||
| if (fs.existsSync("./nuxt-router-override.config.js")) { | |||
| router = require("./nuxt-router-override.config").default; | |||
| } | |||
| // eslint-disable-next-line no-empty | |||
There was a problem hiding this comment.
📝 単にfinallyブロックを削除してもよさそうですが、なんらかの意図があるかもしれないので無効化しています。
munierujp
commented
Jan 10, 2024
| @@ -33,6 +33,7 @@ const _make_tilejson = (dir, base_name) => { | |||
|
|
|||
| // load config | |||
| const list = require(`${CONFIG_DIR}list.json`) | |||
| // eslint-disable-next-line array-callback-return | |||
There was a problem hiding this comment.
📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。
munierujp
commented
Jan 10, 2024
| @@ -248,10 +248,12 @@ export default { | |||
| self.mapConfig.layer_settings, | |||
| source.updated_search_key | |||
| ); | |||
| // eslint-disable-next-line array-callback-return | |||
There was a problem hiding this comment.
📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。
munierujp
commented
Jan 10, 2024
| markers.map((marker) => { | ||
| categories[marker.category] = true; | ||
| }); | ||
| source.updated_at = updated_at; | ||
| // eslint-disable-next-line array-callback-return |
There was a problem hiding this comment.
📝 単にforEachに置き換えてもよさそうですが、なんらかの意図があるかもしれないので無効化しています。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要 | About
ESLint関連パッケージを新しいバージョンに更新します。
なるべく新しいバージョンに更新していますが、更新により発生したエラーの解消が難しい場合は、それ以前のバージョンにとどめています。
既存コードでエラーが検知された場合、意図的なものなのかどうか判断つかないため、ひとまずコメントで無効化しています。
動作確認方法 | How to check
スクリーンショット | Screenshot
なし