-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: base_uri or baseURI in curlrequest? #9265
Comments
Its not bug. See return new CURLRequest(
$config,
new URI($options['base_uri'] ?? null),
$response,
$options
);
It looks weird, but it works |
@neznaika0 But in the manual, it's 'baseURI ': $client = service('curlrequest', [ |
Right. $curl = service('curlrequest', [
'baseURI' => 'https://example.com/api/v1/',
'start_url' => 'https://example.com/',
]); |
Yes, this seems like a bug created when we transited from Feel free to send a PR with the fix. |
PHP Version
8.1
CodeIgniter4 Version
4.5.4
CodeIgniter4 Installation Method
Manual (zip or tar.gz)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
fpm-fcgi
Database
No response
What happened?
In the manual and CodeIgniter\HTTP\CURLRequest->parseOptions, it's 'baseURI '. But in Config\Services::curlrequest, it's 'base_uri'.
Steps to Reproduce
View the code
Expected Output
Use one of 'baseURI' and 'base_uri'.
Anything else?
No response
The text was updated successfully, but these errors were encountered: