Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove withValue semaphore and replace with refcount tracking #943

Open
emizzle opened this issue Oct 8, 2024 · 0 comments
Open

fix: remove withValue semaphore and replace with refcount tracking #943

emizzle opened this issue Oct 8, 2024 · 0 comments
Labels
Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@emizzle
Copy link
Contributor

emizzle commented Oct 8, 2024

Remove the semaphore in withValue. withValue needs manual refcount tracking with async due to raw pointers.

Note that the semaphore was created as a fix to #162.

See #914 and #937 (comment) for context.
@emizzle emizzle added the Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details label Oct 8, 2024
@emizzle emizzle mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emizzle