Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double representation of data in several places #41

Open
codyduong opened this issue Aug 19, 2024 · 0 comments
Open

Remove double representation of data in several places #41

codyduong opened this issue Aug 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@codyduong
Copy link
Owner

We double represent some data, this was originally meant as a convenience but may not accurately represent the gtk4 state, or it may be an unnecessary double storage of values.

pub struct Base {
  // pub classes: Vec<String>,
  // pub classes_temp: Vec<String>,
  pub halign: Option<Align>,
  pub hexpand: bool,
  pub valign: Option<Align>,
  pub vexpand: bool,
}
pub struct BoxInner {
  // pub base: Base,
  pub homogeneous: Option<bool>,
  // pub widgets: Vec<WidgetController>,
}

And so on... Notably, we do need to keep these for Reactives so is it worth the effort to remove these if we end up supporting reactive broadly? Instead maybe we should consider not adding it to new props as was done in 88002c2, but keep existing ones?

@codyduong codyduong added enhancement New feature or request question Further information is requested labels Aug 19, 2024
@codyduong codyduong added this to the unknown milestone Aug 19, 2024
@codyduong codyduong self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant