Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hot reload via lua coroutine.reset #5

Closed
codyduong opened this issue Jun 26, 2024 · 0 comments · Fixed by #23
Closed

fix hot reload via lua coroutine.reset #5

codyduong opened this issue Jun 26, 2024 · 0 comments · Fixed by #23
Assignees
@codyduong
Labels
bug Something isn't working priority high
Milestone
0.1.0

Comments

@codyduong
Copy link
Owner 

let _ = coroutine.reset(lua.load(user_script).into_function().unwrap());

If we reload into an errorful state, the unwrap will not safely crash, causing Rust to panic as well preventing further hot reloads.
@codyduong codyduong added the bug Something isn't working label Jun 26, 2024
@codyduong codyduong self-assigned this Jun 26, 2024
@codyduong codyduong reopened this Jun 28, 2024
@codyduong codyduong added this to the 0.1.0 milestone Jul 16, 2024
@codyduong codyduong mentioned this issue Aug 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyduong codyduong

Labels
bug Something isn't working priority high
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

merge dev to master codyduong/hitokage
1 participant
@codyduong