Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ambiguity with BarPosition, BarOffset, and other behavior #63

Open
codyduong opened this issue Jan 24, 2025 · 1 comment
Open

Resolve ambiguity with BarPosition, BarOffset, and other behavior #63

codyduong opened this issue Jan 24, 2025 · 1 comment
Assignees
@codyduong
Labels
blocked documentation Improvements or additions to documentation priority high question Further information is requested
Milestone
0.1.0

Comments

@codyduong
Copy link
Owner

I don't recall the reasoning for BarOffset naming. It should probably be called BarInset or BarMagin instead, as it should always add a margin between the bar and the main workspace. Normal padding can be achieved via css so it is not necessary. TODO: deprecate and remove old behavior (which was inconsistent anyways).
@codyduong codyduong added documentation Improvements or additions to documentation priority high question Further information is requested labels Jan 24, 2025
@codyduong codyduong self-assigned this Jan 24, 2025
@codyduong
Copy link
Owner Author

Blocked by #10

codyduong added a commit that referenced this issue Jan 24, 2025
@codyduong
fix(bar.rs): use native windows api to reserve space instead of komorebi
56a9a48 
resolves #62, further work needed in #63
@codyduong codyduong added this to the 0.1.0 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyduong codyduong

Labels
blocked documentation Improvements or additions to documentation priority high question Further information is requested
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@codyduong