From 13c00cc1f32fc9894eb193a8570df09702d47f7d Mon Sep 17 00:00:00 2001 From: Pramod S Date: Tue, 22 Oct 2024 09:18:18 +0200 Subject: [PATCH] replaced extracting modelId numeric value to use array slice to remove polynamial expression warning --- .../src/utilities/fetchDMModelIdFromRevisionId.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/viewer/packages/data-providers/src/utilities/fetchDMModelIdFromRevisionId.ts b/viewer/packages/data-providers/src/utilities/fetchDMModelIdFromRevisionId.ts index dd9ae3a814..4038ed19b6 100644 --- a/viewer/packages/data-providers/src/utilities/fetchDMModelIdFromRevisionId.ts +++ b/viewer/packages/data-providers/src/utilities/fetchDMModelIdFromRevisionId.ts @@ -42,8 +42,12 @@ export async function fetchDMModelIdFromRevisionId( } function extractNumericId(externalId: string): number | null { - const match = externalId.match(/\d+$/); - return match ? parseInt(match[0], 10) : null; + const lastUnderscoreIndex = externalId.lastIndexOf('_'); + if (lastUnderscoreIndex === -1) { + return null; + } + const numericPart = externalId.slice(lastUnderscoreIndex + 1); + return numericPart.length > 0 && !isNaN(Number(numericPart)) ? parseInt(numericPart, 10) : null; } function getModelIdQuery(revisionExternalId: string, space: string) {