Bug Bash Feb 2024

[Zizzamia]

Describe the bug and the steps to reproduce it

Time to catch some bugs and ideas for BOAT

What's the expected behavior?

No response

What version of the libraries are you using?

No response

[Sneh1999]

Number of wallets we support right now are low

[Sneh1999]

Everyone has the same avatar image, should be randomized

[Sneh1999]

Twitter handle should open twitter:

[Sneh1999]

This div currently doesnt portray any relevant information:

[arsood]

Buy Me a Coffee flow doesn't work anymore again. When I attempt to purchase, I get to the pending state and it is stuck there even after verifying on my wallet.

Also, the memo is not added and doesn't show on refresh.

[Sneh1999]

Links dont work here

[arsood]

Mint NFT flow doesn't seem to work. Just stuck on minting in progress even after confirming in wallet.

[Sneh1999]

I dont think testnet NFT's show up in the wallet, so this message might not be right

[arsood]

When there are a lot of memos in the Buy Me a Coffee page, the guide is pushed down way too far. Should we either 1. move the guide somewhere else or 2. paginate the memos?

[Sneh1999]

List here is incomplete and doesnt match the README

[robpolak]

Everyone has the same avatar image, should be randomized

Why not ENS profile image??

[Sneh1999]

Buy Me a Coffee flow doesn't work anymore again. When I attempt to purchase, I get to the pending state and it is stuck there even after verifying on my wallet.

Also, the memo is not added and doesn't show on refresh.

It seems to be working for me, not sure

[robpolak]

Error is not obvious and text entry boxes are disabled:

I think we should:

1. Give the error some color to stand out
2. Give text boxes a more pronounced style when disabled.

[robpolak]

Text should wrap :

[eragon512]

Rendering too many items without a limit

[eragon512]

[Phone landscape view] Logout button gets cut off and is not inaccessible even while scrolling in the page

[danimesq]

@Sneh1999
"Number of wallets we support right now are low"
What you modified to replace SmartWallet by the WalletConnect modal?

"This div currently doesnt portray any relevant information:"
In the current implementation, I didn't see this div. Maybe because my environment is localhost rather than production?

@arsood
"When there are a lot of memos in the Buy Me a Coffee page, the guide is pushed down way too far. Should we either 1. move the guide somewhere else or 2. paginate the memos?"
Going to be fixed via #516.

@eragon512
"Rendering too many items without a limit"
Same as the above addressing.

@robpolak
"Text should wrap :"
This issue has been fixed already.

I will try to submit some PRs to fix the following issues:

• Bug Bash Feb 2024 #366 (comment) (suggested by @Sneh1999 ; implemented in: buy-me-coffee: Make twitter usernames clickable #527)
• Bug Bash Feb 2024 #366 (comment)
• Bug Bash Feb 2024 #366 (comment)
• Bug Bash Feb 2024 #366 (comment) (already fixed)
• Bug Bash Feb 2024 #366 (comment)

[danimesq]

I'll have to halt my PRs, because: I've heard somewhere that BOAT is going to be ditched to focus on onchain-kit. Basing that rumour, the repo has no commits for more than a month.

ping @arsood @Zizzamia to know news about this repo, so I may feel comfortable to send PRs to a template that hasn't been abandonned.

[Zizzamia]

Yup, OnchainKit is the priority at the moment. And there is an active plan to build a small collection of Templates based on OnchainKit.

Those templates are probably going to live inside the OnchainKit repo.

Thank you for caring, and reaching out. I will say, if you want to contribute, https://github.com/coinbase/onchainkit is the place.

As soon as we have Templates in the OnchainKit repo, I am probably going to deprecate this one.

[danimesq]

@Zizzamia
"Those templates are probably going to live inside the OnchainKit repo."
Couldn't BOAT be one of these templates?
An idea is to use "git pull --allow-unrelated-histories" to keep the current history of BOAT's repo.
Or making every template their own repos instead of a monorepo?

Just think it's sad for BOAT's code to be wasted, and its commits history as well.

[Zizzamia]

You right!
Let keep this repo, and I will do a few adjustments this week:

• simplify the concept of Templates, and remove the CLI, so each repo is one template
• rename this repo to something like onchain-app-template-buy, and it will focus on the Buy Me Coffee experience
• create new repos inside @coinbase focus on other template like mint or game or xyz

@danimesq what do you think about that?

[danimesq]

@Zizzamia
I think this makes sense! Let's see now the opinion of Base/OnchainKit team 🙏

So, a separate CLI for choosing a template repo the user will get?
Or, why not keeping the templates+CLI a monorepo as a boilerplate to kickstart OnchainKit?

[Zizzamia]

I started refactoring BOAT into something more simple.

Also as you noticed, we just launch https://github.com/coinbase/onchain-app-template, to help simplify how we are approaching templates.