Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom output formatters #94

Open
smiller171 opened this issue Apr 24, 2019 · 2 comments
Open

Support custom output formatters #94

smiller171 opened this issue Apr 24, 2019 · 2 comments

Comments

@smiller171
Copy link

I'm using Atlantis to put my plans in GH PRs, and it would be great if landscape could better support the diff language format. Just a flag that would put the -/+ operators always at the start of the line.

Current:

Switched to workspace "test".

~ aws_ecs_service.webapp
    task_definition:   "redacted_webapp:64" => "${aws_ecs_task_definition.webapp.family}:${max("${aws_ecs_task_definition.webapp.revision}", "${aws_ecs_task_definition.webapp.revision}")}"

-/+ aws_ecs_task_definition.webapp (new resource required)
    id:                      "redacted_webapp" => "<computed>" (forces new resource)
    arn:                     "arn:aws:ecs:redacted:redacted:task-definition/redacted_webapp:64" => "<computed>"
    container_definitions:   "name": "MAIL_PROTOCOL",
                                      "value": "smtp"
                                    }
                                  ],
                                  "essential": true,
                             -    "image": "redacted.dkr.ecr.redacted.amazonaws.com/redacted:82bd2bb",
                             +    "image": "redacted.dkr.ecr.redacted.amazonaws.com/redacted:124c156",
                                  "logConfiguration": {
                                    "logDriver": "awslogs",
                                    "options": {
                                      "awslogs-create-group": "true",
                                      "awslogs-group": "php-logs-test",
                                  ],
                                  "environment": [
                              
                                  ],
                                  "essential": true,
                             -    "image": "redacted.dkr.ecr.redacted.amazonaws.com/nginx:82bd2bb",
                             +    "image": "redacted.dkr.ecr.redacted.amazonaws.com/nginx:124c156",
                                  "links": [
                                    "redacted"
                                  ],
                                  "logConfiguration": {
                                    "logDriver": "awslogs", (forces new resource)
    network_mode:            "" => "<computed>"
    revision:                "64" => "<computed>"

Plan: 1 to add, 1 to change, 1 to destroy.

Proposed:

Switched to workspace "test".

~ aws_ecs_service.webapp
    task_definition:   "redacted_webapp:64" => "${aws_ecs_task_definition.webapp.family}:${max("${aws_ecs_task_definition.webapp.revision}", "${aws_ecs_task_definition.webapp.revision}")}"

-/+ aws_ecs_task_definition.webapp (new resource required)
    id:                      "redacted_webapp" => "<computed>" (forces new resource)
    arn:                     "arn:aws:ecs:redacted:redacted:task-definition/redacted_webapp:64" => "<computed>"
    container_definitions:   "name": "MAIL_PROTOCOL",
                                      "value": "smtp"
                                    }
                                  ],
                                  "essential": true,
-                                 "image": "redacted.dkr.ecr.redacted.amazonaws.com/redacted:82bd2bb",
+                                 "image": "redacted.dkr.ecr.redacted.amazonaws.com/redacted:124c156",
                                  "logConfiguration": {
                                    "logDriver": "awslogs",
                                    "options": {
                                      "awslogs-create-group": "true",
                                      "awslogs-group": "php-logs-test",
                                  ],
                                  "environment": [
                              
                                  ],
                                  "essential": true,
-                                 "image": "redacted.dkr.ecr.redacted.amazonaws.com/nginx:82bd2bb",
+                                 "image": "redacted.dkr.ecr.redacted.amazonaws.com/nginx:124c156",
                                  "links": [
                                    "redacted"
                                  ],
                                  "logConfiguration": {
                                    "logDriver": "awslogs", (forces new resource)
    network_mode:            "" => "<computed>"
    revision:                "64" => "<computed>"

Plan: 1 to add, 1 to change, 1 to destroy.
@sds sds added the enhancement label May 3, 2019
@sds
Copy link
Contributor

sds commented May 3, 2019

Open to a pull request adding this functionality.

@smiller171
Copy link
Author

I would but I've never used Ruby. I looked through the code a bit but couldn't quite grok what I'd need to change where.

@sds sds changed the title Feature Request: GitHub diff language format Support for custom output formatters Dec 20, 2019
@sds sds changed the title Support for custom output formatters Support custom output formatters Dec 20, 2019
@coinbase coinbase locked and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants