From 1531a1b0ff2ba67a2b5e54610e18c6beb2022212 Mon Sep 17 00:00:00 2001 From: Charles Leifer Date: Tue, 9 Apr 2024 10:22:57 -0500 Subject: [PATCH] Additional test coverage and fix psycopg3 failure. --- .github/workflows/tests.yaml | 6 ++++-- tests/base.py | 1 + tests/migrations.py | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 1312e437a..b4ca2637e 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -24,7 +24,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: [3.7, 3.9, "3.10"] + python-version: [3.7, 3.9, "3.11"] peewee-backend: - "sqlite" - "postgresql" @@ -35,8 +35,10 @@ jobs: include: - python-version: 3.7 peewee-backend: cockroachdb - - python-version: "3.10" + - python-version: "3.11" peewee-backend: cockroachdb + - python-version: "3.11" + peewee-backend: psycopg3 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 diff --git a/tests/base.py b/tests/base.py index 3bff8562f..8259886ea 100644 --- a/tests/base.py +++ b/tests/base.py @@ -61,6 +61,7 @@ def get_in_memory_db(**params): IS_MYSQL = BACKEND.startswith(('mysql', 'maria')) IS_POSTGRESQL = BACKEND.startswith(('postgres', 'psycopg')) IS_CRDB = BACKEND in ('cockroach', 'cockroachdb', 'crdb') +IS_PSYCOPG3 = BACKEND == 'psycopg3' def make_db_params(key): diff --git a/tests/migrations.py b/tests/migrations.py index 7e34c703b..0e55a42d1 100644 --- a/tests/migrations.py +++ b/tests/migrations.py @@ -8,6 +8,7 @@ from .base import IS_CRDB from .base import IS_MYSQL from .base import IS_POSTGRESQL +from .base import IS_PSYCOPG3 from .base import IS_SQLITE from .base import IS_SQLITE_25 from .base import IS_SQLITE_35 @@ -331,6 +332,7 @@ class Meta: def test_rename_gh380_sqlite_legacy(self): self.test_rename_gh380(legacy=True) + @skip_if(IS_PSYCOPG3, 'Psycopg3 chokes on the default value.') def test_add_default_drop_default(self): with self.database.transaction(): migrate(self.migrator.add_column_default('person', 'first_name',