Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background-color from tab #107

Open
stevepiercy opened this issue Sep 20, 2024 · 0 comments
Open

Remove background-color from tab #107

stevepiercy opened this issue Sep 20, 2024 · 0 comments

Comments

@stevepiercy
Copy link
Member

stevepiercy commented Sep 20, 2024

When using a theme in dark mode, the background color of the tab makes it illegible.

Screenshot 2024-09-19 at 5 26 39 PM

This is due to the CSS:

.http-example .caption.selected {
  background-color: #fff;
}

To work around this issue, I added a custom style to Plone Sphinx Theme in plone/plone-sphinx-theme#29.

.http-example .caption.selected {
  background-color: unset;
}

Screenshot 2024-09-19 at 5 30 39 PM

However, I can see why you would want to set the background color for themes that have a light grey content background, such as Read The Docs Sphinx Theme.

Screenshot 2024-09-19 at 5 29 52 PM

Here's how it would look, and the difference is negligible.

Screenshot 2024-09-19 at 5 29 21 PM

If you think this would be a good improvement, I can submit a PR.

See also plone/plone.restapi#1815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant