-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: collectiveidea/protoc-gen-twirp_ruby
base: v1.1.1
head repository: collectiveidea/protoc-gen-twirp_ruby
compare: main
Commits on May 24, 2024
-
Add local rake task for regenerating the example code
Rather than having to try and remember or look up the command to run code generation for the example, hit the easy button and create a simple rake task for it.
Configuration menu - View commit details
-
Copy full SHA for a87b6cb - Browse repository at this point
Copy the full SHA a87b6cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4466f8 - Browse repository at this point
Copy the full SHA c4466f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cde8adc - Browse repository at this point
Copy the full SHA cde8adcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0383f40 - Browse repository at this point
Copy the full SHA 0383f40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a32a0d - Browse repository at this point
Copy the full SHA 6a32a0dView commit details -
Split out rspec and standardrb GitHub actions
By keeping these separate, we can more easily tell at-a-glance what is causing a GitHub action failure. This also allows the `spec` and `standard` rake tasks to run in parallel as separate actions. Previously, the combined action simply ran `rake` which would run specs and then only ran standard when specs passed.
Configuration menu - View commit details
-
Copy full SHA for d2e36bb - Browse repository at this point
Copy the full SHA d2e36bbView commit details -
Add additional Rubies to spec action
Given our gemspec defines Ruby >= 3.0, let's ensure that's actually true by running our specs across all support versions.
Configuration menu - View commit details
-
Copy full SHA for 30cc380 - Browse repository at this point
Copy the full SHA 30cc380View commit details -
Configuration menu - View commit details
-
Copy full SHA for e62f634 - Browse repository at this point
Copy the full SHA e62f634View commit details -
Configuration menu - View commit details
-
Copy full SHA for 555c424 - Browse repository at this point
Copy the full SHA 555c424View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dedff2 - Browse repository at this point
Copy the full SHA 6dedff2View commit details -
Merge pull request #37 from collectiveidea/split-spec-and-standard-ac…
…tions GitHub Action improvements
Configuration menu - View commit details
-
Copy full SHA for aae22e5 - Browse repository at this point
Copy the full SHA aae22e5View commit details -
Add
simplecov
gem for developmentDon't forget to `rm Gemfile.lock && bundle install`
Configuration menu - View commit details
-
Copy full SHA for f479441 - Browse repository at this point
Copy the full SHA f479441View commit details -
Run specs with coverage when COVERAGE is truthy
We default to not running with coverage to speed up the suite. To run with coverage locally, use: ``` COVERAGE=true bundle exec rake spec ```
Configuration menu - View commit details
-
Copy full SHA for 757022b - Browse repository at this point
Copy the full SHA 757022bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f478a - Browse repository at this point
Copy the full SHA 67f478aView commit details -
Merge pull request #38 from collectiveidea/add-simplecov-and-code-cli…
…mate Add simplecov dev dependency and integrate Code Climate
Configuration menu - View commit details
-
Copy full SHA for 04013d2 - Browse repository at this point
Copy the full SHA 04013d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ffc7a5 - Browse repository at this point
Copy the full SHA 2ffc7a5View commit details -
Merge pull request #39 from collectiveidea/add-test-coverage-badge
Add test coverage badge to README.md
Configuration menu - View commit details
-
Copy full SHA for 328e071 - Browse repository at this point
Copy the full SHA 328e071View commit details
Commits on May 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a711ee4 - Browse repository at this point
Copy the full SHA a711ee4View commit details -
Delete custom "be empty scaffolding" matcher
The plugin never generates empty scaffolding anymore. As such, we no longer need our custom matcher to validate the empty scaffolding content.
Configuration menu - View commit details
-
Copy full SHA for e4f8100 - Browse repository at this point
Copy the full SHA e4f8100View commit details -
Deprecate and warn on
skip-empty
flag.This is now the default behavior.
Configuration menu - View commit details
-
Copy full SHA for dd26ed5 - Browse repository at this point
Copy the full SHA dd26ed5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2db72e - Browse repository at this point
Copy the full SHA c2db72eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 707a597 - Browse repository at this point
Copy the full SHA 707a597View commit details -
Remove
skip-empty
warning; error instead.Rather than a soft deprecation here over two releases, we remove recognizing the flag entirely. The migration path is small/easy for this change (updating the command to simply remove the option), and we don't have a very large user base at the moment.
Configuration menu - View commit details
-
Copy full SHA for ba15374 - Browse repository at this point
Copy the full SHA ba15374View commit details -
Merge pull request #40 from collectiveidea/make-skip-empty-the-defaul…
…t-and-remove-flag Make `skip-empty` the default behavior and deprecate option
Configuration menu - View commit details
-
Copy full SHA for 739e63f - Browse repository at this point
Copy the full SHA 739e63fView commit details -
Add
#to_anchor
String extensionThis will convert a string into an URL HREF anchor. Specifically, we anticipate using this for headings in GitHub markdown files to construct links to those headings.
Configuration menu - View commit details
-
Copy full SHA for 04f3ebf - Browse repository at this point
Copy the full SHA 04f3ebfView commit details -
Add
release:latest_github_release
taskRequires installing the `gh` CLI. Gets the latest release from GitHub and outputs the version to STDOUT.
Configuration menu - View commit details
-
Copy full SHA for 545fa32 - Browse repository at this point
Copy the full SHA 545fa32View commit details -
Add
release:create_github_release
taskLeverages the `gh` CLI to create a release. This uses the same command that we specified in the README for releasing, but programmatically determines the version to specify and automatically crafts the proper release notes (linking to the CHANGELOG and the diff view).
Configuration menu - View commit details
-
Copy full SHA for 38bc660 - Browse repository at this point
Copy the full SHA 38bc660View commit details -
Override default gem
release
taskWe don't want the `release:rubygem_push` task to execute at all. Previously we used `gem_push=no bundle exec rake release` for this.. but since we're customize `release` to _also_ create a GitHub release, let's just remove the RubyGem push to it will never accidentally trigger if someone forgets the `gem_push=no` ENV var.
Configuration menu - View commit details
-
Copy full SHA for ae40231 - Browse repository at this point
Copy the full SHA ae40231View commit details -
Simplify README.md release instructions.
Our `rake release` task override does everything we need for release now. There are no more manual steps.
Configuration menu - View commit details
-
Copy full SHA for b0ff5ea - Browse repository at this point
Copy the full SHA b0ff5eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ed83a3 - Browse repository at this point
Copy the full SHA 7ed83a3View commit details
Commits on May 29, 2024
-
Merge pull request #41 from collectiveidea/streamline-release-task
Streamline gem release with bundler gem task release override
Configuration menu - View commit details
-
Copy full SHA for 891adce - Browse repository at this point
Copy the full SHA 891adceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5506401 - Browse repository at this point
Copy the full SHA 5506401View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80ce8b4 - Browse repository at this point
Copy the full SHA 80ce8b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 751d48a - Browse repository at this point
Copy the full SHA 751d48aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9d6d9f - Browse repository at this point
Copy the full SHA f9d6d9fView commit details -
Tweak publish action to only build and push
Previously the action was running `bundle exec rake release`, which was doing too much. The GitHub publish_gem action automatically runs when a release tag is pushed. The only thing the action should do is build the gem and publish to RubyGems.
Configuration menu - View commit details
-
Copy full SHA for 3b87e66 - Browse repository at this point
Copy the full SHA 3b87e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for df8bb61 - Browse repository at this point
Copy the full SHA df8bb61View commit details -
Merge pull request #43 from collectiveidea/tweak-github-publish-action
Tweak publish action to only build and push
Configuration menu - View commit details
-
Copy full SHA for e9e2b69 - Browse repository at this point
Copy the full SHA e9e2b69View commit details
There are no files selected for viewing
This file was deleted.