Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newest frontend update (partially) broke previews #7134

Closed
NuclearWaste02 opened this issue Mar 8, 2025 · 6 comments
Closed

Newest frontend update (partially) broke previews #7134

NuclearWaste02 opened this issue Mar 8, 2025 · 6 comments
Labels
Bug Something is confirmed to not be working properly. Custom Nodes Bug Bugs caused by downstream custom nodes Frontend Issue relates to the frontend UI (litegraph).

Comments

@NuclearWaste02
Copy link

Expected Behavior

When having previews enabled during ksampler generation, you used to be able to right click and "Open Image" on the finalized preview and view it in the web browser.

Actual Behavior

Now it only renders previews at an extremely low quality. Clicking "Open Image", "Save Image" or "Copy Image" all don't work anymore and redirect to a blob image instead of the local file in the temp folder.

Steps to Reproduce

Generate an image with a sampler that generates a realtime preview (e.g. KSampler Efficient). Once the image is generated, right click on the preview and hit "Open Image".

Debug Logs

N/A

Other

Issue persists after latest update. This merge seemed to cause this issue.

@NuclearWaste02 NuclearWaste02 added the Potential Bug User is reporting a bug. This should be tested. label Mar 8, 2025
@huchenlei huchenlei added Bug Something is confirmed to not be working properly. Frontend Issue relates to the frontend UI (litegraph). and removed Potential Bug User is reporting a bug. This should be tested. labels Mar 8, 2025
@huchenlei huchenlei marked this as a duplicate of #7139 Mar 8, 2025
@huchenlei
Copy link
Collaborator

I am not sure if it is a frontend issue starting from v1.11 frontend. The preview quality in between v1.10 and v1.11 frontend are not significant to me.

v1.10 preview

Image

Image

v1.11 preview

Image

Image

Is the high quality preview feature provided by a custom node? Can you try reproduce the issue with --disable-all-custom-nodes flag?

@LukeG89
Copy link

LukeG89 commented Mar 8, 2025

I've tested the issue, but I had no problem opening, copy-pasting and saving an image from Preview Image node (@NuclearWaste02 is this the problem, right?)

This is frontend v1.11.8 and all custom nodes disabled:

Open-Copy-Save.mp4

(btw, I have no issues even with my nodes enabled)

@NuclearWaste02
Copy link
Author

I'm using a custom KSampler from the efficiency nodes pack. Coincidentally the same one used in the duplicate issue. It seems like the issue is with that node and not the new frontend update. My apologies!

@huchenlei huchenlei added the Custom Nodes Bug Bugs caused by downstream custom nodes label Mar 9, 2025
@Vik71it
Copy link

Vik71it commented Mar 9, 2025

I'm experiencing a similar problem with the standard ksampler node. I can't remember if the "old" behaviour was different with this node (until now I also used Efficiency Ksampler), but it seems right now that also changing the quality of the preview has no effect on the resulting preview of the KSampler node. I attach the result tested with the default workflow

Please let me know if there is some specifical test that could be useful to understand if it is a general problem or a custom node, and the behaviour of the standard ksampler is correct (also, for batches of file, it is shown only the preview for the first one)

Image
Image

@christian-byrne
Copy link
Contributor

also, for batches of file, it is shown only the preview for the first one

Do you mean your expectation is an image grid of previews on the KSampler?

@Vik71it
Copy link

Vik71it commented Mar 9, 2025

Do you mean your expectation is an image grid of previews on the KSampler?

Something similar to the "Preview Image" behaviour for a batch. But, since I was using a different KSampler node, not the standard one, I can't really say that this was the behaviour in previous releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is confirmed to not be working properly. Custom Nodes Bug Bugs caused by downstream custom nodes Frontend Issue relates to the frontend UI (litegraph).
Projects
None yet
Development

No branches or pull requests

5 participants