Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and in-page extension API cleanup #216

Open
da-kami opened this issue Aug 3, 2021 · 1 comment
Open

Name and in-page extension API cleanup #216

da-kami opened this issue Aug 3, 2021 · 1 comment

Comments

@da-kami
Copy link
Member

da-kami commented Aug 3, 2021

Make sure that the names make sense:

  • Waves = the web application the user sees ^= the fontend the lender serves and the borrower uses ^= the product?
  • "Extension" = the complete extension (including the wallet + backup functionality)
    • The interface def in Waves is called "WavesProvider" which is confusing
  • Bobtimus = the lender backend

Waves + Bobtimus is shipped / deployed together so we can change APIs easily.
The Extension is shipped separately - so the interface between Waves and Extension is critical and breaking changes will require the user to take action (i.e. install a new Extension version). Thus, we should have a look at the API and see if we want to change things before going into production.

@da-kami
Copy link
Member Author

da-kami commented Aug 3, 2021

waves => fronted
extension => extension

wavesProvider => provider / walletProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant