Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/v1 is part of VaultConfig #3

Open
cneijenhuis opened this issue Jun 27, 2021 · 0 comments
Open

/v1 is part of VaultConfig #3

cneijenhuis opened this issue Jun 27, 2021 · 0 comments

Comments

@cneijenhuis
Copy link
Contributor

Right now /v1 has to be provided with the VaultConfig.apiUrl (like here: https://github.com/adrobisch/tresor/blob/main/src/test/scala/com/drobisch/tresor/vault/MongoAtlasSpec.scala#L16 )

Should there be a v2, it'd probably be cleaner to have that as a separate config field and keep the apiUrl free of the version used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant