Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on re-exporting Contravariant? #134

Open
locallycompact opened this issue Oct 3, 2018 · 3 comments
Open

Thoughts on re-exporting Contravariant? #134

locallycompact opened this issue Oct 3, 2018 · 3 comments

Comments

@locallycompact
Copy link
Collaborator

Now that contravariant is in base I wonder if it makes sense to re-export it in rio? My instinct says that contramap, Predicate, Equivalence and Comparison have a low risk of collision and are sufficiently general that they should be simply re-exported. However, divide, choose, etc may be better namespaced.

@snoyberg
Copy link
Collaborator

snoyberg commented Oct 4, 2018

What version of base added this typeclass? We want to keep compatibility with older versions of base, and I'd rather avoid either a conditional API or adding extra dependencies for older versions of GHC.

@locallycompact
Copy link
Collaborator Author

@snoyberg
Copy link
Collaborator

snoyberg commented Oct 4, 2018

In which case, I'd say we should hold off until at least GHC 8.6 is considered the default compiler version to start with, and probably until at least GHC 8.2 is no longer commonly supported. Then we can introduce a conditional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants