Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cycle detected #7493

Closed
mihaimaruseac opened this issue Jul 28, 2024 · 13 comments
Closed

Build cycle detected #7493

mihaimaruseac opened this issue Jul 28, 2024 · 13 comments

Comments

@mihaimaruseac
Copy link
Contributor

   In the dependencies for temporary-1.3:
     * random dependency cycle detected: random, temporary, doctest,
       prettyprinter-ansi-terminal, optparse-applicative, tasty, tasty-bench, random,
       test-framework, test-framework-quickcheck2, half, OpenGLRaw, OpenGL, OpenAL, ALUT
mihaimaruseac added a commit that referenced this issue Jul 28, 2024
@mihaimaruseac
Copy link
Contributor Author

It seems it was caused by doctest (cc @sol)

@sol
Copy link
Contributor

sol commented Jul 29, 2024

Package should not regularly depend on doctest but instead use the documented way: https://github.com/sol/doctest/tree/main?tab=readme-ov-file#running-doctest-for-a-cabal-package

This should be fixed by haskell/random#165.

@mihaimaruseac
Copy link
Contributor Author

Thank you!

@juhp juhp closed this as completed in 9a93a10 Dec 9, 2024
@juhp
Copy link
Contributor

juhp commented Dec 11, 2024

Needs a random release

@juhp juhp reopened this Dec 11, 2024
@juhp
Copy link
Contributor

juhp commented Dec 11, 2024

Still wonder if there would be another way to break the cycle but maybe not?
Since we are still stuck on an old doctest < 0.22.7 because of this.

@sol
Copy link
Contributor

sol commented Dec 11, 2024

Still wonder if there would be another way to break the cycle but maybe not?

Disable tests for random maybe?

@juhp
Copy link
Contributor

juhp commented Dec 12, 2024

Still wonder if there would be another way to break the cycle but maybe not?

Disable tests for random maybe?

Unfortunately that didn't work: the cycle reappears

  In the dependencies for temporary-1.3:
     * random dependency cycle detected: random, temporary, doctest,
       prettyprinter-ansi-terminal, optparse-applicative, tasty, tasty-bench, random,
       test-framework, test-framework-quickcheck2, half, OpenGLRaw, OpenGL, OpenAL, ALUT
   The above is/are needed since temporary is a build target.

juhp added a commit that referenced this issue Dec 12, 2024
This reverts commit a9a916d.

Unfortunately this does not break the dependency cycle
@juhp juhp mentioned this issue Dec 12, 2024
11 tasks
@mihaimaruseac
Copy link
Contributor Author

A similar cycle is now detected for tasty-quickcheck :(

       In the dependencies for hashable-1.5.0.0(-arch-native):
         * tasty-quickcheck dependency cycle detected: tasty-quickcheck, hashable,
           unordered-containers, doctest-parallel, regex-tdfa, tasty-quickcheck, zlib, Agda
       The above is/are needed since hashable is a build target.
       
       In the dependencies for unordered-containers-0.2.20:
         * tasty-quickcheck dependency cycle detected: tasty-quickcheck, hashable,
           unordered-containers, doctest-parallel, regex-tdfa, tasty-quickcheck, zlib, Agda
       The above is/are needed since unordered-containers is a build target.

mihaimaruseac added a commit that referenced this issue Jan 6, 2025
@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 6, 2025

That's weird: tasty-quickcheck itself does not depend on regex-tdfa, it's only its own tests which does. But this should not be a problem for hashable or anyone else?..

Would it break the cycle if you disable tests for tasty-quickcheck?

mihaimaruseac added a commit that referenced this issue Jan 6, 2025
@mihaimaruseac
Copy link
Contributor Author

I can try fully skipping the tests

@mihaimaruseac
Copy link
Contributor Author

That worked. I'll try the same with random/doctest.

@mihaimaruseac mihaimaruseac mentioned this issue Jan 6, 2025
64 tasks
@mihaimaruseac
Copy link
Contributor Author

I think this works, but cannot fully test due to #7615, #7648

mihaimaruseac added a commit that referenced this issue Jan 6, 2025
@mihaimaruseac
Copy link
Contributor Author

This is now fixed, by disabling tests for tasty-quickcheck (second cycle) and the pair of temporary and prettyprinter-ansi-terminal (the original cycle with random/doctest). Closing this as fixed right now.

DanBurton added a commit that referenced this issue Jan 17, 2025
@DanBurton DanBurton mentioned this issue Jan 17, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants