Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autolink Extension not detecting links that start with www #298

Open
rockycodes opened this issue Sep 21, 2023 · 1 comment
Open

Autolink Extension not detecting links that start with www #298

rockycodes opened this issue Sep 21, 2023 · 1 comment

Comments

@rockycodes
Copy link

autolink-java supports detecting WWW links, but the Autolink Extension for commonmark-java does not. This is easily fixed by removing this line so that the default detecting logic for autolink-java will be used. I am happy to submit a pr to do this, but wanted to first check if there is a historical reason for doing it this way since the more limited list seems to have been intentionally added in this change.

Fwiw, this is a blocker for me using the Autolink Extension in my project. If the more limited list of supported link types is intentional, it should be called out in the documentation.

Steps to reproduce the problem (provide example Markdown if applicable):

www.google.com

Expected behavior:

<a href="http://www.google.com" class="text-blue-600" target="_blank">www.google.com</a>

Actual behavior:

<p>www.google.com</p>
@rockycodes rockycodes added the bug label Sep 21, 2023
@rockycodes rockycodes changed the title Autolink Extenstion not detecting links that start with www Autolink Extension not detecting links that start with www Sep 21, 2023
@robinst
Copy link
Collaborator

robinst commented Feb 9, 2024

In bff088e the WWW mode didn't exist yet, that was only added in November 2016: robinst/autolink-java#8 (comment).

So the reason is simply that it hasn't been added as an option to AutolinkExtension. I'd be happy for it to be added, yeah. You can copy how StrikethroughExtension does options (add a builder). And we would probably want our own enum instead of exporting autolink's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants