Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpirV failes to build: #29

Open
mattgodbolt opened this issue Nov 1, 2021 · 6 comments
Open

SpirV failes to build: #29

mattgodbolt opened this issue Nov 1, 2021 · 6 comments
Assignees

Comments

@mattgodbolt
Copy link
Member

CMake Error at CMakeLists.txt:76 (MESSAGE):
    llvm-spirv isn't a known project:
    clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl;flang
@mattgodbolt
Copy link
Member Author

@jzzheng22 do you have any ideas on this? I will re-enable this build to show the error and process we build with.

mattgodbolt added a commit to compiler-explorer/compiler-workflows that referenced this issue Nov 23, 2021
@mattgodbolt
Copy link
Member Author

@AnastasiaStulova
Copy link

It seems, that the translator is built as an LLVM subproject but it is currently an independent project... so the instructions for building it in the LLVM tree are documented here: https://github.com/KhronosGroup/SPIRV-LLVM-Translator#llvm-in-tree-build

Has there been any change in godbolt about spirv-llvm build?

@mattgodbolt
Copy link
Member Author

Not knowingly, but I'll take another look in case some build refactoring i did broke it! thanks for the hint!

@mattgodbolt mattgodbolt self-assigned this Nov 23, 2021
@AnastasiaStulova
Copy link

Ok, it seems that it was a change in LLVM in Sep:
https://reviews.llvm.org/D110016

So my guess is that we should build llvm-spirv differently now... but I wonder if the instructions in the translator repo are up to dat because they only seem to activate clang in cmake...

@AnastasiaStulova
Copy link

Looking at the translator build bots it seems that they never set LLVM_ENABLE_PROJECTS="llvm-spirv" when building in LLVM tree https://github.com/KhronosGroup/SPIRV-LLVM-Translator/runs/4293773208?check_suite_focus=true.

So I feel if we just drop this option from cmake line then the build will succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants