-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versions of the consent forms and other docs #42
Comments
the cons to me is the sheer volume - at the moment 6 languages for the ultimate consent form and 11 for gdrp consent form and 11 for the dua --> as you said, a minor change in 1 file needs to be carried out over many other files ; to me this outweighs the better traceability of changes -- middle ground solution: have English in one file, all other languages in another (ie 3 English and 3 others) |
I don't get the too many files argument... Most likely not any single human would be able to change actual text in all languages at once. And even if needed - editors and |
ok fine, just been lazy ... |
eh, this discussion is more relevant to #43 ;-) but ok, let's continue here:
? as for section ids -- the same, main section title + I could later script adding localized versions so does not need to be done during splitting to not introduce "bugs" (i.e. typos). splitting should really just move text around and possibly add section ids. Any changes to content should be done in separate PRs and later |
done |
Done where? |
through that same PR -- do I need to push it again? (did not look like you merged>?) |
Apparently there was #27 which already exercised versioning a bit. It points to the fact missed there that there is 2 versions of the ultimate -- public and restricted. I feel that we should meld with #27, and also #45 (OBC prefix), and include
followed by the version which would include translation etc as described above: |
What do you think @chrisgorgo @CPernet @vborghe et al of @con/i18n ? ;) |
Sounds reasonable to me! |
regardless or in addition to proper i18n support (now we have i18n teams btw) we need to start versioning the form(s) which would help to also track which translation needs additional changes from previous one.
Two major choices:
use this repo version as a base
<this repo version>.[ult|gdpr|dpi|dua][.<patch>][.language[.LANGUAGEPATCH]]
pros
cons
use separate versions per each document
Use https://semver.org/ at large in a form
MAJOR.MINOR[.language[.LANGUAGEPATCH]]
, with simple logic ofMINOR
goes up upon trivial changes -- typo fixes, reformatting etc.MAJOR
going up whenever anything added to removed..language
is an abbreviation based on https://www.w3schools.com/tags/ref_language_codes.asp.LANGUAGEPATCH
- any changes accumulating on top ofMAJOR.MINOR
for that language. No.language
for english version as the source of all translations. So versions could be1.0
1.0.es.2
. And then when we see main version1.2
but translation still1.0.es.2
we would know that we should update to the changes in that translation between versions 1.0 and 1.2 of the base version.The text was updated successfully, but these errors were encountered: