Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] test_requires in lockfile/SBOM #144

Open
1 task done
dkoerner-festo opened this issue Jul 26, 2024 · 11 comments
Open
1 task done

[question] test_requires in lockfile/SBOM #144

dkoerner-festo opened this issue Jul 26, 2024 · 11 comments
Assignees

Comments

@dkoerner-festo
Copy link

What is your question?

test_requires packages (e.g. gtest) are entered as "requires" in the lockfiles and are therefore also part of the SBOM. I think such requires should not be included in the SBOM. Or is there any reason for this?

Have you read the CONTRIBUTING guide?

  • I've read the CONTRIBUTING guide
@memsharded memsharded self-assigned this Jul 26, 2024
@memsharded
Copy link
Member

Hi @dkoerner-festo

Thanks for your question.

Do you mean the conan sbom:cyclonedx extension command? this is not related to lockfiles, that would be a different thing, maybe we need to move this ticket to the https://github.com/conan-io/conan-extensions repo?

@dkoerner-festo
Copy link
Author

Hi @memsharded ,

I looked at the extension. I was wrong ;) . I thought only the info from the lockfiles was evaluated, but the extension is using the Conan graph information.

In my opinion the test_requires and tool_requires should not part of the SBOM. To filter out these dependencies I would skip all item with "node.context == build" and "node.test == true". Would this be correct?

@memsharded
Copy link
Member

So then, I'll move this ticket to the extensions repo, as this would be to discuss about the conan sbom: extension command. Thanks!

@memsharded memsharded transferred this issue from conan-io/conan Jul 29, 2024
@memsharded
Copy link
Member

In my opinion the test_requires and tool_requires should not part of the SBOM. To filter out these dependencies I would skip all item with "node.context == build" and "node.test == true". Would this be correct?

It would be good to have the feedback from experts, I am not sure what is the expected behavior, or maybe this should be an option for users?

@memsharded
Copy link
Member

Maybe @jkowalleck or @hedtke have some feedback regarding this?

@hedtke
Copy link
Contributor

hedtke commented Aug 13, 2024

Indeed, this detail was not considered before. They should either be ignored, or we add a new flag to add them. Do we have any favorite way here?

@dkoerner-festo
Copy link
Author

I would prefer to ignore by default and add a flag to add them.

@dkoerner-festo
Copy link
Author

#159 solves at least the build context part.

@memsharded
Copy link
Member

Adding --no-test-requires should also be relatively easy, if someone wants to give it a try.

@hedtke
Copy link
Contributor

hedtke commented Dec 9, 2024

I'm on sick leave until August 2025 and will not have the time to work on this

@memsharded
Copy link
Member

Thanks for the feedback @hedtke, I'll try to remember not to ping you, I hope everything goes well in your leave. Thanks very much for everything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants