Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some properties before writing metadata to JSON #102

Open
joosthooz opened this issue Sep 28, 2022 · 0 comments
Open

Remove some properties before writing metadata to JSON #102

joosthooz opened this issue Sep 28, 2022 · 0 comments

Comments

@joosthooz
Copy link
Collaborator

We should carefully consider which items belong in the JSON that is being written to disk.
See #89 (comment)
We should remove cache_location and dir_hash, and remove the re-parsing of cache_location to a pathlib in Dataset.__post_init__. It may still be necessary to initialize cache_location from the location of the metadata file, for example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joosthooz