Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate rel_path as url suffix and relative path in cache #111

Closed
joosthooz opened this issue Oct 17, 2022 · 1 comment
Closed

Differentiate rel_path as url suffix and relative path in cache #111

joosthooz opened this issue Oct 17, 2022 · 1 comment
Assignees
@jonkeane

Comments

@joosthooz
Copy link
Collaborator

we are using rel_path to refer to both a relative path in the cache as well as a relative URL path for downloading. Is there any way that we could differentiate those uses?

Originally posted by @jonkeane in #101 (comment)

Note that this might just be a documentation issue; my first intuition is that we should indeed only support cases in which these 2 are the same. rel_path is the path to the file relative to the table's directory.
@jonkeane jonkeane self-assigned this Oct 20, 2022
@jonkeane jonkeane mentioned this issue Oct 20, 2022
Merged
@joosthooz
Copy link
Collaborator Author

Resolved by #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonkeane jonkeane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonkeane @joosthooz