New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we take the downloading | generating out of `find_close_dataset()` #78

Open

jonkeane opened this issue Sep 19, 2022 · 0 comments

Contributor

jonkeane commented Sep 19, 2022

I found it a bit funny to keep it in there (especially for testing). We could do like we do with find_exact_dataset() and do something like:

ds_out = find_exact_dataset(ds)

if ds_out == []:
  ds_out == find_close_dataset()
  
if ds_out == []:
  ds_out =  ds.download() | ds.generate()
 
if ds_out != ds:
  ds = ds.convert(ds_out)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment