From 21a5d54e9a4a869f696c01714c783ce76fa00c15 Mon Sep 17 00:00:00 2001 From: Sophia Castellarin Date: Mon, 6 Jan 2025 08:49:35 -0800 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tania Allard --- .github/workflows/build_pypi_package.yaml | 2 +- .github/workflows/release.yaml | 3 +-- docusaurus-docs/community/contribute/local-setup-core.md | 2 +- docusaurus-docs/conda-store/introduction.md | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build_pypi_package.yaml b/.github/workflows/build_pypi_package.yaml index bd3816e46..9839f839f 100644 --- a/.github/workflows/build_pypi_package.yaml +++ b/.github/workflows/build_pypi_package.yaml @@ -32,7 +32,7 @@ jobs: - run: echo "Running on conda-store-server" - - name: "Build and check package - conda-store-server 📦" + - name: "Build and check package 📦" uses: hynek/build-and-inspect-python-package@v2 id: baipp with: diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 0dcbb30e8..75c1e8561 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -29,9 +29,8 @@ jobs: with: fetch-depth: 0 - - run: echo "Running on conda-store-server" - - name: "Build and check package - conda-store-server 📦" + - name: "Build and check package 📦" uses: hynek/build-and-inspect-python-package@v2 id: baipp with: diff --git a/docusaurus-docs/community/contribute/local-setup-core.md b/docusaurus-docs/community/contribute/local-setup-core.md index 01c7c97da..d977f3736 100644 --- a/docusaurus-docs/community/contribute/local-setup-core.md +++ b/docusaurus-docs/community/contribute/local-setup-core.md @@ -8,7 +8,7 @@ description: Local development setup for conda-store There are two main ways to set up your local environment and conda-store services (web UI, API server, database, etc.) for development: - Using [Docker and Docker compose](#docker-setup-recommended): This is the recommended approach for working on `conda-store-server` library. -- Using [standalone mode](#standalone-setup): This approach avoids using docker and starts the conda-store services as one process +- Using [standalone mode](#standalone-setup): This approach avoids using Docker and starts the conda-store services as one process :::important You need a [local copy of the `conda-store` repository](community/contribute/contribute-code#setup-for-local-development) for the development setup. diff --git a/docusaurus-docs/conda-store/introduction.md b/docusaurus-docs/conda-store/introduction.md index 0f7c5cc40..55865936b 100644 --- a/docusaurus-docs/conda-store/introduction.md +++ b/docusaurus-docs/conda-store/introduction.md @@ -6,7 +6,7 @@ description: Introduction to conda-store (core) documentation # conda-store (core) -The [`conda-store` repository on GitHub][conda-store-repo] contains the conda-store application. It has two entrypoints +The [`conda-store` repository on GitHub][conda-store-repo] contains the conda-store application. It has two entrypoints: - **`conda-store-server`**: web server that provides the `conda-store` "service" through a REST API - **`conda-store-worker`**: celery worker that runs actions for conda-store. For example, building, locking and installing environments