-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTHN-1982] Implement OAuthBearer mechanism for Kafka client to fetch JWT token by communicating with SPIRE agent #1015
Open
chang-you
wants to merge
11
commits into
master
Choose a base branch
from
spire_producer_example_0623
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+369
−0
Open
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f3f7a55
Created handleJWTTokenRefreshEvent and retrieveJWTToken functions
chang-you 1fdc6b0
Updated closer error and changed oauthConf to principal
chang-you d1f1fbd
Modified config to use the defualt unsecure method, pass logicalClust…
chang-you 87ba39f
Deleted imported workload API, clean the code
chang-you 1f69a9e
Deleted Spire workload API
chang-you 9e3286f
Updated go.mod
chang-you ff33ee2
Updated Context, added spire_consumer_example.go
chang-you 728a155
Updated spire_consumer_example.go and comment description.
chang-you 92056a9
remove some unnecessary blocks
chang-you decdb12
Empty-Commit
chang-you 89573cd
update CHANGELOG.md and examples/.gitignore
chang-you File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updated closer error and changed oauthConf to principal
commit 1fdc6b0aaa6233b58530d75e3b87a865bbe55dfa
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding this file: Would it make sense to keep just one file (either the consumer or the producer, but not both)?
Since this is an example to demonstrate the usage of a custom oauth handler, what we're actually doing with the client shouldn't be the main focus of the example, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comments! That makes sense too.
@arvindth what do you think? Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, a single producer or consumer example is probably good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@milindl @arvindth but I noticed that under the
examples
folder, most of the previous examples: protobuf/oauthbearer/json/avro include both producer example and consumer example, should we keep both?