Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alphabetical ordering for TOPK with Strings #886

Open
rodesai opened this issue Mar 8, 2018 · 1 comment
Open

Consider alphabetical ordering for TOPK with Strings #886

rodesai opened this issue Mar 8, 2018 · 1 comment

Comments

@rodesai
Copy link
Contributor

rodesai commented Mar 8, 2018

The default String comparator we use for comparing strings orders all upper-case characters after lower-case characters. This is likely to be inconsistent with what a user would expect.

@big-andy-coates
Copy link
Contributor

big-andy-coates commented Mar 8, 2018

Our TopK style aggregators use reverse comparators, regardless of type. So no only does it put uppercase after lower, it also puts numbers after lower.

Though changing this would break anyone currently using strings with TopK...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants