Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty-print reactor_conf.conf in orchestrator.log #1467

Open
ktdreyer opened this issue May 18, 2020 · 1 comment
Open

pretty-print reactor_conf.conf in orchestrator.log #1467

ktdreyer opened this issue May 18, 2020 · 1 comment

Comments

@ktdreyer
Copy link
Contributor

The orchestrator.log file prints the reactor configuration like this:

atomic_reactor.plugins.reactor_config - INFO - reading config content ...

It simply prints a string representation of very large dict. This is hard for human users to read when trying to understand the current settings. It is also hard for developers to compare log files with tools like "diff".

By contrast, the ContainerTasker class uses json.dumps() when logging, for example:

logger.debug(json.dumps(info, indent=2))
logger.info(json.dumps(version, indent=2))

It would be great to pretty-print reactor_conf.conf as well.

This change would make OSBS easier to understand.

@athos-ribeiro
Copy link
Contributor

Hi Ken!

+1 here! @rcerven , @MartinBasti , thoughts?

Ken, would you mind providing a patch for this? Otherwise we could try to line it up for one of us OSBSers, but this would most likely be some low priority technical debt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants