Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split precompilation and runtime behavior in different traits #799

Open
jprendes opened this issue Jan 14, 2025 · 2 comments
Open

Split precompilation and runtime behavior in different traits #799

jprendes opened this issue Jan 14, 2025 · 2 comments

Comments

@jprendes
Copy link
Collaborator

Currently the precompilation behavior of a shim is defined in the same Engine trait where the runtime behavior is specified.

The two behaviors are linked, in the sense that they need to be compatible. But they are also independent, as precompilation needs to run in the shim process while the runtime runs out of process.

I propose we split them in two different traits, where the Precompiler trait could be an associated type to the Engine trait.

@jprendes jprendes moved this to Todo in Runwasi 1.0 Jan 14, 2025
@Mossaka
Copy link
Member

Mossaka commented Jan 14, 2025

We talked about this issue in detail in our last community call. Please check the notes here: https://docs.google.com/document/d/1aOJ-O7fgMyRowHD0kOoA2Z_4d19NyAvvdqOkZO3Su_M/edit?tab=t.0

@fibonacci1729
Copy link

fibonacci1729 commented Jan 16, 2025

+1; had the same thought while working on #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants